fix(ui): 1692 fix exemption label on registraiton page#1732
Merged
Conversation
| } | ||
| return activeReg.value?.strRequirements?.isPrincipalResidenceRequired | ||
| const getPrRequired = (): string => | ||
| activeReg.value?.strRequirements?.isPrincipalResidenceRequired |
Collaborator
There was a problem hiding this comment.
dont we need to update the test cases for the changes in this file. i only see one path being tested which is the Required one. Are the rest already covered somewhere?
Collaborator
Author
There was a problem hiding this comment.
added test cases for the changes, thanks!
Collaborator
|
Temporary Url for review: https://strr-examiner-dev--pr-1732-7sejv8ja.web.app |
|
Collaborator
|
Temporary Url for review: https://strr-examiner-dev--pr-1732-7sejv8ja.web.app |
| nocStatus: null | ||
| } | ||
|
|
||
| export const mockHostRegistrationNotRequired: HostRegistrationResp = { |
Collaborator
There was a problem hiding this comment.
[nit]
not really a fan of the naming of this variable here lol.
jimmypalelil
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License